Feature/2824 date input #2864
Merged
Feature/2824 date input #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #2824 |
archiewood
requested changes
Nov 29, 2024
archiewood
reviewed
Nov 29, 2024
archiewood
reviewed
Nov 29, 2024
|
Date Input w/ calendar (@steeze-ui/svelte-icon)
Date Input w/ inline title
Date Input w/ range + title (no calendar icon)
|
|
Added more margin between icon and text (m1 --> m2).
Date range for reference
|
|
calendar icon is improved The separating bar between the Date Input and Jan 1, 1970 looks different to that used in the Dropdown to me (too heavy, does not extend high or low enough) Can we match the styling |
zachstence
previously requested changes
Dec 17, 2024
packages/ui/core-components/src/lib/atoms/inputs/date-input/_DateInput.svelte
Outdated
Show resolved
Hide resolved
csjh
approved these changes
Dec 18, 2024
packages/ui/core-components/src/lib/atoms/inputs/date-input/DateInput.svelte
Outdated
Show resolved
Hide resolved
ItsMeBrianD
reviewed
Dec 18, 2024
|
|
||
| <script> | ||
| import DateInput from './_DateInput.svelte'; | ||
| // import { Query } from '@evidence-dev/sdk/usql'; |
There was a problem hiding this comment.
Suggested change
| // import { Query } from '@evidence-dev/sdk/usql'; |
ItsMeBrianD
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created DateInput component that builds off the DateRange structure. Redirects /components/date-range/ --> /components/date-input/
Allows users to access a single date or ranged date input calendar
Checklist