Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace babel-plugin-makepot #2666

Closed
manzoorwanijk opened this issue Apr 7, 2020 · 4 comments
Closed

Replace babel-plugin-makepot #2666

manzoorwanijk opened this issue Apr 7, 2020 · 4 comments

Comments

@manzoorwanijk
Copy link
Contributor

@WordPress has moved @wordpress/babel-plugin-makepot to WP CLI

WordPress/gutenberg#14780 (comment)

@nicolad
Copy link
Contributor

nicolad commented Apr 7, 2020

Based on this: https://developer.wordpress.org/block-editor/developers/internationalization/#create-translation-file
and this message: https://eventespresso.slack.com/archives/C080DDVLM/p1586266708397300
I assume that there is no need to replace babel-plugin-makepot with another babel plugin.
@manzoorwanijk please confirm
cc @tn3rb

@manzoorwanijk
Copy link
Contributor Author

manzoorwanijk commented Apr 7, 2020

Yeah, no other babel plugin. It needs to be integrated with CLI build process. May be require wp-cli in composer.json then use ./vendor/bin/wp for wp-cli.

@tn3rb
Copy link
Member

tn3rb commented May 5, 2020

@manzoorwanijk
Copy link
Contributor Author

I have created this issue upstream, hope that it gets fixed soon.

@tn3rb tn3rb closed this as completed Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants