Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

remove api/client usage in http package #1364

Closed
acud opened this issue May 1, 2019 · 1 comment
Closed

remove api/client usage in http package #1364

acud opened this issue May 1, 2019 · 1 comment
Assignees
@acud
Labels
good first issue http/rpc/ipc

Comments

@acud
Copy link
Member

acud commented May 1, 2019

the http package has a reference to api/client in some tests of the http package. this limits the possibility to use references to consts contracted by the http package in the client library due to cyclic dependency.

we should get rid of the api client in the http package and test using raw http only in the http package.
@acud acud mentioned this issue May 1, 2019
Merged
@acud acud self-assigned this May 3, 2019
@acud
Copy link
Member Author

acud commented May 5, 2019

done

@acud acud closed this as completed May 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@acud acud

Labels
good first issue http/rpc/ipc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acud