Fix most of the typos in the comments #1838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricmoo
added
documentation
ricmoo
reviewed
Oct 4, 2021
| @@ -1277,8 +1277,8 @@ type _Location = { | |||
| export function parse(code: string, options?: ParserOptions): Node { | |||
| if (options == null) { options = { }; } | |||
|
|
|||
| // Since jison allows \n, \r or \r\n line endings, we need some | |||
There was a problem hiding this comment.
Jison is the application used to process the file (a JavaScript equivalent to Bison). ;)
There was a problem hiding this comment.
No worries. I just finished going through your PR and merging it locally.
Thanks a lot for your attention to detail. :)
ricmoo
added a commit
that referenced
this pull request
Oct 16, 2021
|
Merged. Thanks! :) |
ricmoo
added
fixed/complete
This was referenced Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.