Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add confirmations field from transaction response #156

Conversation

jlindberg-oss
Copy link

Provided, at least, by the Etherscan provider.

Provided, at least, by the Etherscan provider.
@mccoysc
Copy link

mccoysc commented Apr 23, 2018

could add whisper protocol to this library?thks

@ricmoo
Copy link
Member

ricmoo commented Apr 23, 2018

Whisper and Swarm are something I have been thinking about. I would prefer to wait until there are better third-party backends available, but more importantly, a non-stateful “shh_newIdentity”... it does that exist now? I haven’t touched whisper in over a year. I want private keys in the client to be able to sign and send messages, not on the node.

@mccoysc
Copy link

mccoysc commented Apr 24, 2018

It seems that it works perfectly good.
https://github.com/nkbai/go-ethereum-example/blob/master/p2pmessage/p2pmessage.go

the above is an example in go.

@ricmoo
Copy link
Member

ricmoo commented Jul 24, 2018

@mccoysc The example above is stateful, it uses shh.NewKeyPair, so it isn't very useful unless you have your own node; there is no way to share a node, since anyone with access to it could send a message as anyone else, and read everyone else's messages. :s

@ricmoo
Copy link
Member

ricmoo commented Jul 24, 2018

I have added an issue for this feature in v4. It will be available soon, in a generic way to all providers. :)

So, I'll close this PR.

Thanks!

@ricmoo ricmoo closed this Jul 24, 2018
@jlindberg-oss
Copy link
Author

Cool -- thanks for following up! +1 to doing it the right way 😄

@ricmoo
Copy link
Member

ricmoo commented Oct 5, 2018

This has been added in 4.0.3.

@jlindberg-oss
Copy link
Author

jlindberg-oss commented Oct 5, 2018 via email

asnov added a commit to asnov/ethers.js that referenced this pull request Oct 14, 2018
Merge commit '3736a1571480a0f69d632d6fc3bde549cbe46162' into fix/tslib

* commit '3736a1571480a0f69d632d6fc3bde549cbe46162': (41 commits)
  Updated dist files.
  Added automatic event parsing for contract transaction receipts from tx.wait.
  Added ability to wait for a specific number of confirmations (ethers-io#229).
  Fix for geth-etc (official geth is fine), which returns Receipts before the blockHash is synced to the database.
  Fixed confirmations tests and bootstrap fast blockNumber.
  Added confirmations to TransactionResponse (ethers-io#156, ethers-io#238).
  Fixed nested errors for providers that were masking true error (ethers-io#292).
  Updated dist files.
  Added version to errors.
  Fixed French and Spanish for browsers without Uint8Array.forEach.
  Added French and Spanish includes to phantomjs test page.
  Increased timeout for querying npm registry.
  Updated dist files.
  Added French and Spanish wordlist dist files.
  Added French and Spanish BIP-39 wordlists (ethers-io#191).
  Added support for JSON serialized BigNumbers in the constructor (ethers-io#288).
  Fixed scrypt for long passwords (ethers-io#223).
  Updated dist files.
  Added chainId as supported override for contract transactions.
  Fixed wildcard events and made nested events more robust (ethers-io#289).
  ...

Conflicts:
	dist/ethers.min.js
	dist/ethers.min.js.map
	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants