-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add confirmations field from transaction response #156
add confirmations field from transaction response #156
Conversation
Provided, at least, by the Etherscan provider.
could add whisper protocol to this library?thks |
Whisper and Swarm are something I have been thinking about. I would prefer to wait until there are better third-party backends available, but more importantly, a non-stateful “shh_newIdentity”... it does that exist now? I haven’t touched whisper in over a year. I want private keys in the client to be able to sign and send messages, not on the node. |
It seems that it works perfectly good. the above is an example in go. |
@mccoysc The example above is stateful, it uses |
I have added an issue for this feature in v4. It will be available soon, in a generic way to all providers. :) So, I'll close this PR. Thanks! |
Cool -- thanks for following up! +1 to doing it the right way 😄 |
This has been added in |
Awesome! Thanks!
…On Thu, Oct 4, 2018 at 6:37 PM Richard Moore ***@***.***> wrote:
This has been added in 4.0.3.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#156 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfaIvxkRnpILW3CyWYcknAGcUm8si1Pzks5uhrfTgaJpZM4TLaM2>
.
|
Merge commit '3736a1571480a0f69d632d6fc3bde549cbe46162' into fix/tslib * commit '3736a1571480a0f69d632d6fc3bde549cbe46162': (41 commits) Updated dist files. Added automatic event parsing for contract transaction receipts from tx.wait. Added ability to wait for a specific number of confirmations (ethers-io#229). Fix for geth-etc (official geth is fine), which returns Receipts before the blockHash is synced to the database. Fixed confirmations tests and bootstrap fast blockNumber. Added confirmations to TransactionResponse (ethers-io#156, ethers-io#238). Fixed nested errors for providers that were masking true error (ethers-io#292). Updated dist files. Added version to errors. Fixed French and Spanish for browsers without Uint8Array.forEach. Added French and Spanish includes to phantomjs test page. Increased timeout for querying npm registry. Updated dist files. Added French and Spanish wordlist dist files. Added French and Spanish BIP-39 wordlists (ethers-io#191). Added support for JSON serialized BigNumbers in the constructor (ethers-io#288). Fixed scrypt for long passwords (ethers-io#223). Updated dist files. Added chainId as supported override for contract transactions. Fixed wildcard events and made nested events more robust (ethers-io#289). ... Conflicts: dist/ethers.min.js dist/ethers.min.js.map package-lock.json
Provided, at least, by the Etherscan provider.