Why does getLogs assume fromBlock: "latest" instead of 0 like queryFilter?

[samlaf]

It seems incongruent that these two functions don't have the same api. For eg.,

const logs = await ethers.provider.getLogs(AaveV3Pool.filters.LiquidationCall());
console.log("num logs:", logs.length)

const events = await AaveV3Pool.queryFilter(AaveV3Pool.filters.LiquidationCall());
console.log("num events:", events.length)

returns

num logs: 0
num events: 1669

In order to get the logs, we need to change fromBlock inside the LiquidationCall:

const liquidationCallFilterWithBlockRanges = {
    ...AaveV3Pool.filters.LiquidationCall(),
    fromBlock: 0,
};
const logs = await ethers.provider.getLogs(liquidationCallFilterWithBlockRanges);
console.log("num logs:", logs.length)

and then we get the logs.

Is there a good reason for this? If yes, then might I suggest adding the possibility to specify toBlock and fromBlock in the call to filters.LiquidationCall()? Perhaps as optional parameters, something like filters.Liquidation({fromBlock: 0}).

[zemse]

If fromBlock is not passed, ethers does not pass it as well to the node, and it seems the node assumes it as "latest". I agree this is a behaviour that is unexpected from a common dev perspective, even I was once stuck with getLogs giving me an empty array. I wish it would add the fromBlock: 0 if dev doesn't provide a value. But honestly I don't think this change would be made for v5 since it would probably be breaking some code. cc: @ricmoo, do you think changing getLogs behaviour would make sense in v6?