Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethash: check possible invalid RLP input data in tests #943

Closed
jochem-brouwer opened this issue Nov 6, 2020 · 1 comment · Fixed by #1411
Closed

Ethash: check possible invalid RLP input data in tests #943

jochem-brouwer opened this issue Nov 6, 2020 · 1 comment · Fixed by #1411
Labels
package: ethash

Comments

@jochem-brouwer
Copy link
Member

jochem-brouwer commented Nov 6, 2020 •
edited
Loading

validBlockRlp from ethash_block_rlp_tests.json has a lot of extraData (>32 bytes) if you try to create the block. The block number is 1 so it is not a Genesis block. This RLP should be invalid. What is the purpose of this extra data? Why is there an invalid block used as test in ethash?
This was referenced Nov 6, 2020
Merged
Closed
@holgerd77
Copy link
Member

These kind of smaller issues should be validated and/or tackled at some point so that they don't lay around forever. 😛

@acolytec3 acolytec3 mentioned this issue Aug 18, 2021
Merged
@ryanio ryanio linked a pull request Aug 18, 2021 that will close this issue
ethash: Switch out valid block RLP test data #1411
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: ethash
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ethash: Switch out valid block RLP test data ethereumjs/ethereumjs-monorepo
2 participants
@holgerd77 @jochem-brouwer