Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish typing cleanup for CLI params #3045

Closed
acolytec3 opened this issue Sep 19, 2023 · 2 comments · Fixed by #3150
Closed

Finish typing cleanup for CLI params #3045

acolytec3 opened this issue Sep 19, 2023 · 2 comments · Fixed by #3150

Comments

@acolytec3
Copy link
Contributor

Our client CLI params is currently @ts-ignored because of at least 2 issues related to how yargs parses params that are configured with array: true.

Both bootnodes and transports are currently defined as being array params and yargs parses these as a type (string | number)[] | undefined.

In the case of transports, it really doesn't even make sense to have this as an array since we only support rlpx. We should rework this option so that it is a simple boolean param and starts up an RLPXServer inside client/src/config.ts if this param isn't passed (or is passed as true) and start the client with no servers if --transports=false is passed.

In both cases, the typing should be cleaned up and we ensure we can remove this @ts-ignore without Typescript complaining about type mismatches.

@holgerd77
Copy link
Member

Then rename to --networking or otherwise plain ---rlpx (maybe networking is easier, guess there are a lot of people who are not so firm with networking topology) might be a more intuitive version.

@acolytec3
Copy link
Contributor Author

The transports part of this was dealt with in #3069

@acolytec3 acolytec3 linked a pull request Nov 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants