Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common: add BSC chain config #1535

Closed
zfesd opened this issue Oct 20, 2021 · 5 comments
Closed

Common: add BSC chain config #1535

zfesd opened this issue Oct 20, 2021 · 5 comments

Comments

@zfesd
Copy link

zfesd commented Oct 20, 2021

Would be really nice to get native BSC support :)

@ryanio ryanio changed the title Common Common: add BSC chain config Oct 20, 2021
@ryanio
Copy link
Contributor

ryanio commented Oct 20, 2021

Start from community member @srgl, would need further confirmation parameters are valid/correct: #1394 (comment)

@zfesd
Copy link
Author

zfesd commented Dec 1, 2021

Would this help for getting a common made for BSC?

{ChainID: 56 Homestead: 0 DAO: DAOSupport: false EIP150: 0 EIP155: 0 EIP158: 0 Byzantium: 0 Constantinople: 0 Petersburg: 0 Istanbul: 0, Muir Glacier: 0, Ramanujan: 0, Niels: 0, MirrorSync: 5184000, Bruno: 13082000, Berlin: , YOLO v3: , Engine: parlia}

@holgerd77
Copy link
Member

Hi there,
thanks for the suggestion.

We've discussed this in the team again. Sorry, but if the BSC chain is coming with its own hardforks (we didn't know about that before), this is rather too deep reaching into our code bases and we wouldn't do an integration on such a level for a third-party chain.

So we would rather encourage you (or anyone else interested) to do a wrapper or a fork on the library and add a respective chain files together with dedicated hardfork and EIP definitions you need for your chain. We have a lot of generic structures in place (checking for EIP activations, comparing HFs,...) which should significantly help you on such an implementation.

Will close here.

@mjpowersjr
Copy link

Sorry to revive a old thread - does anyone know if a BSC fork being developed / maintained?

I'm not finding anything via Google, etc. - I figured it was worth a shot to ask here before digging deeper into the codebase.

@acolytec3
Copy link
Contributor

I'm not aware of anything. As noted above, because BSC has hardforks that aren't based on Mainnet specs, Common won't support it 100% out of the box though it theoretically shouldn't take too much effort to add in whatever additional fork/EIPs have been added on the BSC side. This is a super simplistic example but #1527 details the changes required to add the last hardfork (Arrow Glacier) to the code base and could serve as a rough guide on how to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants