Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate Atlantis Upgrade Scheduling Call #80

Closed
soc1c opened this issue Jun 4, 2019 · 18 comments
Closed

Intermediate Atlantis Upgrade Scheduling Call #80

soc1c opened this issue Jun 4, 2019 · 18 comments

Comments

@soc1c
Copy link
Contributor

soc1c commented Jun 4, 2019

It became apparent that certain parts of the Ethereum Classic community are appreciating an accelerated hardfork schedule. To avoid confusion, rushing protocol upgrades, and putting the network at risk of a potential split, I propose scheduling an intermediate atlantis-upgrade scheduling call to discuss and agree on a realistic timeline for ECIP-1054

ref #79

ETC Core Devs Call - Atlantis Scheduling

When: Friday, June 07, 2019, 1pm UTC, 30 minutes max.

Where: Youtube Livestream https://www.youtube.com/watch?v=hDVrKDSOCWA&feature=youtu.be
You can stream the call and chat and ask questions on Youtube Livestream. If you want access to the Hangouts to chat via voice, you'll need to message @soc1c or @YazzyYaz for a link to that. Due to limit on voice call attendees by Google, we ask that only those who are interested in using voice to ask for the invite to the Hangouts.

Agenda

  • Quick client teams check-in
    • Geth / Multi-Geth
    • Parity Ethereum
    • IOHK Mantis
  • Discuss timeline for the protocol upgrade
    • Morden Classic and Kotti Classic testnet
    • Ethereum Classic mainnet

There are two competing proposals right now, I will give them letters, and propose a 3rd as a compromise:

  • [A] Original ECIP-1054 schedule
    • 1_039_000 on Kotti Classic PoA-testnet (early August 2019)
    • 4_723_000 on Morden Classic PoW-testnet (early August 2019)
    • 8_750_000 on Ethereum Classic PoW-mainnet (mid-September 2019)
  • [B] ETCLabs "July 1st" schedule
    • N/A on Kotti Classic PoA-testnet
    • immediately on Morden Classic PoW-testnet (early June 2019)
    • 8_343_000 on Ethereum Classic PoW-mainnet (July 1st 2019)
  • [C] Moderately accelerated schedule
    • 716_617 on Kotti Classic PoA-testnet (two weeks from now)
    • 4_729_274 on Morden Classic PoW-testnet (two weeks from now)
    • 8_500_000 on Ethereum Classic PoW-mainnet (six weeks after successfull testnet forks)
@wired1924
Copy link

Where is the link for the call?

@meowsbits
Copy link
Member

meowsbits commented Jun 5, 2019

Typo: [B] should s/June 1/July 1/

@YazzyYaz
Copy link
Contributor

YazzyYaz commented Jun 5, 2019

Typo: [B] should s/June 1/July 1/

I updated it, thanks for pointing it out.

@meowsbits
Copy link
Member

re: [B] again, "immediately" is obviously incomplete and impossible. What is the tangible proposed number? (If there is one?)

@cats9000
Copy link

cats9000 commented Jun 6, 2019

Ask for invite here if you are not on that discord.

@soc1c could I please have an invitation?

@ghost
Copy link

ghost commented Jun 6, 2019

1pm UTC is 9am EST right (just to confirm and not to miss it)

@mikeyb
Copy link
Member

mikeyb commented Jun 6, 2019

@soc1c
Copy link
Contributor Author

soc1c commented Jun 6, 2019

@YazzyYaz
Copy link
Contributor

YazzyYaz commented Jun 6, 2019

After talks with @soc1c @mikeyb and @tokenhash I have updated the ECIP discussion location to the Youtube Livestream here: https://www.youtube.com/watch?v=hDVrKDSOCWA&feature=youtu.be

@tzdybal
Copy link

tzdybal commented Jun 7, 2019

Unfortunately I'm not able to participate in the call, but I want to share my opinion as a developer.

I fully endorse option A - Original ECIP schedule.

According to my experience with previous forks, it's impossible to avoid network split with tight schedule. In my opinion even the original schedule leave just enough time for informational campaign and software update of the nodes. Because of the decentralized nature of the network, where you can't directly contact all participants, updates take time.

I would also like to remind all parties, that regardless of what will be decided, changes has to be implemented thru ECIP process. In my opinion, change of a activation block is such a significant change, that ECIP should go back to "Draft" state and then wait 2 weeks in "Last call".

@soc1c
Copy link
Contributor Author

soc1c commented Jun 7, 2019

Thanks for everyone, I updated the ECIP according to the results of the call in #82

@soc1c soc1c closed this as completed Jun 7, 2019
@YazzyYaz
Copy link
Contributor

YazzyYaz commented Jun 7, 2019

Livestream of Discussion: https://www.youtube.com/watch?v=hDVrKDSOCWA

@zmitton
Copy link
Contributor

zmitton commented Jun 7, 2019

My understanding is that we are tentatively targeting a compromise date at block 8,500,000 (early august).

Please thumbs down if this is inaccurate or you have a pressing objection it.

@ghost
Copy link

ghost commented Jun 7, 2019

The agreed dates with Terry Culver's feedback are:

716_617 on Kotti Classic PoA-testnet (two weeks from now)
4_729_274 on Morden Classic PoW-testnet (two weeks from now)
8_500_000 on Ethereum Classic PoW-mainnet (six weeks after successfull testnet forks)

[the above is from #ecips channel posted by @stevanlohja]

@soc1c
Copy link
Contributor Author

soc1c commented Jun 10, 2019

The agreed dates with Terry Culver's feedback are:

716_617 on Kotti Classic PoA-testnet (two weeks from now)
4_729_274 on Morden Classic PoW-testnet (two weeks from now)
8_500_000 on Ethereum Classic PoW-mainnet (six weeks after successfull testnet forks)

[the above is from #ecips channel posted by @stevanlohja]

Thanks

@zmitton
Copy link
Contributor

zmitton commented Jun 11, 2019

with regard to eip161 @meowsbits there is a contract used by the EF to delete some empties. I got it from Martin Swende. here it is, but it only cleans the ones from the attack, not all of them. My understanding is that the attacker must have generated addresses in a predictable mathematical way, and this contract just erases those ones using his same math. we can give this a try, hopefully it will remove the vast majority. It is also possible to remove all of them, but its a bit difficult to find them due to the "secure tree" abstraction - the fact that a key use in the tree is the hash of the address. I can find the keys, but then I need thei preimages. I can probably get those another way but would have to comb through every transaction.

tldr: the cleanup happens after the hard fork, so we should move forward, either way. plus i have the contract that can probably do a very good job

@soc1c soc1c reopened this Jun 11, 2019
@soc1c soc1c closed this as completed Jun 11, 2019
@zmitton
Copy link
Contributor

zmitton commented Jun 13, 2019

the repo for ethereum's state clearing process eip161 is forked into my repo here

if anyone wants to get involved please subscribe or open issues there

@devfdn
Copy link

devfdn commented Jun 14, 2019

what successful testing means for atlantis time schedule?? i am reeading geth code and see this ethereumproject/go-ethereum#717!! can somebodey please explain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants