Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to include EIP-3541 in London #307

Closed
axic opened this issue Apr 28, 2021 · 8 comments
Closed

Proposal to include EIP-3541 in London #307

axic opened this issue Apr 28, 2021 · 8 comments

Comments

@axic
Copy link
Member

axic commented Apr 28, 2021

We propose to include EIP-3541 in London (it is only an EIP PR right now, but hopefully gets merged in a few days).

This change is very simple itself and is the first step of the larger EIP-3540, which we hope to have included in Shanghai.

It is important to consider 3541 for London, otherwise 3540 would be delayed to Cancun at earliest. We think including 3541 will not cause any delay to London, given its simplicity.

@timbeiko
Copy link
Contributor

We agreed on ACD 112 to move EIP-3541 to CFI and decide about London inclusion on the following call. It's been updated in the tracker board.

@axic
Copy link
Member Author

axic commented May 10, 2021

The draft has been merged (https://eips.ethereum.org/EIPS/eip-3541) and comprehensive tests are in a PR to ethereum/tests (ethereum/tests#835).

@timbeiko
Copy link
Contributor

Thanks, @axic. Added the proper commit in the Baikal spec.

@axic
Copy link
Member Author

axic commented May 10, 2021

Thanks! Could you also change the link on the left hand side? It still points to the PR.

@timbeiko
Copy link
Contributor

Good catch, done 👍

@axic
Copy link
Member Author

axic commented May 13, 2021

@timbeiko we have pushed unit tests into the EIP and the status was also updated to review. Perhaps you want to change the commit hash to include the tests, but the comprehensive test changes are in ethereum/tests#835 anyway.

@timbeiko
Copy link
Contributor

Updated in the baikal spec, @axic 👍

@timbeiko
Copy link
Contributor

Closing given we agreed to include this in London in #309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants