Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure that IsCancun is used as much as possible #166

Closed
gballet opened this issue Jan 6, 2022 · 2 comments
Closed

ensure that IsCancun is used as much as possible #166

gballet opened this issue Jan 6, 2022 · 2 comments
Assignees

Comments

@gballet
Copy link
Member

gballet commented Jan 6, 2022

In many instances, evm.txContext.Accesses != nil can be replaced by a call to IsCancun(), we should strive for using this, in order to make it easier for reviewers to figure out that this code will not activate outside of a verkle tree-enabled context, even if Accesses are somehow activated.

@gballet gballet self-assigned this Jan 18, 2022
@gballet
Copy link
Member Author

gballet commented Jan 18, 2022

@jwasinger did most of the work, there are a couple issues left in PR gballet/go-ethereum#60:

core/vm/evm.go:	if evm.Accesses != nil && value.Sign() != 0 {
core/vm/evm.go:	if err == nil && evm.Accesses != nil {

@gballet
Copy link
Member Author

gballet commented Jan 18, 2022

Solved with 4087d8b

@gballet gballet closed this as completed Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant