From 5baa2bf61cc0553fbb6dd39ba945d888425dca44 Mon Sep 17 00:00:00 2001 From: Delweng Zheng Date: Thu, 14 Jun 2018 23:28:18 +0800 Subject: [PATCH 1/3] accounts: remove deadcode isSigned --- accounts/abi/numbers.go | 9 --------- 1 file changed, 9 deletions(-) diff --git a/accounts/abi/numbers.go b/accounts/abi/numbers.go index 0cd97cc66f36..a551520912c1 100644 --- a/accounts/abi/numbers.go +++ b/accounts/abi/numbers.go @@ -48,12 +48,3 @@ var ( func U256(n *big.Int) []byte { return math.PaddedBigBytes(math.U256(n), 32) } - -// checks whether the given reflect value is signed. This also works for slices with a number type -func isSigned(v reflect.Value) bool { - switch v.Type() { - case intTS, int8TS, int16TS, int32TS, int64TS, intT, int8T, int16T, int32T, int64T: - return true - } - return false -} From af16c11d353dc80017ed25de42d717e251e8950e Mon Sep 17 00:00:00 2001 From: Delweng Zheng Date: Fri, 15 Jun 2018 17:54:40 +0800 Subject: [PATCH 2/3] accounts/abi: remove isSigned test case --- accounts/abi/numbers_test.go | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/accounts/abi/numbers_test.go b/accounts/abi/numbers_test.go index b9ff5aef17d3..d25a5abcb516 100644 --- a/accounts/abi/numbers_test.go +++ b/accounts/abi/numbers_test.go @@ -19,7 +19,6 @@ package abi import ( "bytes" "math/big" - "reflect" "testing" ) @@ -32,13 +31,3 @@ func TestNumberTypes(t *testing.T) { t.Errorf("expected %x got %x", ubytes, unsigned) } } - -func TestSigned(t *testing.T) { - if isSigned(reflect.ValueOf(uint(10))) { - t.Error("signed") - } - - if !isSigned(reflect.ValueOf(int(10))) { - t.Error("not signed") - } -} From 553e4095db6a213e23b9ec29daf981fd2c4cecb2 Mon Sep 17 00:00:00 2001 From: Delweng Zheng Date: Sat, 16 Jun 2018 11:30:40 +0800 Subject: [PATCH 3/3] account: remove unused variables --- accounts/abi/numbers.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/accounts/abi/numbers.go b/accounts/abi/numbers.go index a551520912c1..4d706846dacd 100644 --- a/accounts/abi/numbers.go +++ b/accounts/abi/numbers.go @@ -31,17 +31,11 @@ var ( uint16T = reflect.TypeOf(uint16(0)) uint32T = reflect.TypeOf(uint32(0)) uint64T = reflect.TypeOf(uint64(0)) - intT = reflect.TypeOf(int(0)) int8T = reflect.TypeOf(int8(0)) int16T = reflect.TypeOf(int16(0)) int32T = reflect.TypeOf(int32(0)) int64T = reflect.TypeOf(int64(0)) addressT = reflect.TypeOf(common.Address{}) - intTS = reflect.TypeOf([]int(nil)) - int8TS = reflect.TypeOf([]int8(nil)) - int16TS = reflect.TypeOf([]int16(nil)) - int32TS = reflect.TypeOf([]int32(nil)) - int64TS = reflect.TypeOf([]int64(nil)) ) // U256 converts a big Int into a 256bit EVM number.