Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to modify the period for collecting metrics? #31039

Closed
pysel opened this issue Jan 17, 2025 · 6 comments
Closed

Is it possible to modify the period for collecting metrics? #31039

pysel opened this issue Jan 17, 2025 · 6 comments

Comments

@pysel
Copy link

pysel commented Jan 17, 2025

It would be great if it were possible to modify the interval for metrics collection. Afaik, the interval is hardcoded here: https://github.com/ethereum/go-ethereum/blob/master/cmd/utils/flags.go#L2004.

This is especially relevant when running geth in docker, when you can't easily modify the source code. is there a particular reason for the choice of 10s interval?

@MariusVanDerWijden
Copy link
Member

What would be your use case for modifying the metrics collection interval?
We will discuss this in our next triage would be great to understand your motivation for this!

@pysel
Copy link
Author

pysel commented Jan 21, 2025

I am testing the performance of geth on hardware with lower specs than recommended. I need lower intervals to see potential spikes in cpu/mem usage that could otherwise be averaged

@pysel
Copy link
Author

pysel commented Jan 22, 2025

@MariusVanDerWijden, do you know if docker image ethereum/client-go is built from this dockerfile: https://github.com/ethereum/go-ethereum/blob/v1.13.14/Dockerfile? I tried manually rebuilding the image with shorter metrics collection interval, but the new container built from that image wasn't able to launch

@rjl493456442
Copy link
Member

Here are some instructions for building docker image manually.

  • Download the source code and apply your own modification on top
  • Launch the docker daemon
  • Run docker build . -t xxx
  • Docker push

@Brindle79
Copy link

Should ETH engineer an platform writers be informed of the situation an issue have been raised pull request bug fixes

GitHub right audit report

@MariusVanDerWijden
Copy link
Member

Looks like you were able to locally modify it @pysel
Thanks for reporting, I will close this issue for now. Feel free to reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants