-
Notifications
You must be signed in to change notification settings - Fork 20.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it possible to modify the period for collecting metrics? #31039
Comments
What would be your use case for modifying the metrics collection interval? |
I am testing the performance of geth on hardware with lower specs than recommended. I need lower intervals to see potential spikes in cpu/mem usage that could otherwise be averaged |
@MariusVanDerWijden, do you know if docker image ethereum/client-go is built from this dockerfile: https://github.com/ethereum/go-ethereum/blob/v1.13.14/Dockerfile? I tried manually rebuilding the image with shorter metrics collection interval, but the new container built from that image wasn't able to launch |
Here are some instructions for building docker image manually.
|
Should ETH engineer an platform writers be informed of the situation an issue have been raised pull request bug fixes GitHub right audit report |
Looks like you were able to locally modify it @pysel |
It would be great if it were possible to modify the interval for metrics collection. Afaik, the interval is hardcoded here: https://github.com/ethereum/go-ethereum/blob/master/cmd/utils/flags.go#L2004.
This is especially relevant when running
geth
in docker, when you can't easily modify the source code. is there a particular reason for the choice of 10s interval?The text was updated successfully, but these errors were encountered: