From 857b46e4bdfcec62e9fa51a6990791d76dbad2f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Bylica?= Date: Tue, 31 Mar 2020 23:15:52 +0200 Subject: [PATCH 1/3] ci: Drop -DNATIVE=ON for Windows builds NATIVE=ON for MSVC enables AVX instruction set. This make Windows release binaries unusable on CPUs not having AVX. --- appveyor.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appveyor.yml b/appveyor.yml index f9ca5d2fef..3e16e05658 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -26,7 +26,7 @@ install: before_build: - call "%ProgramFiles(x86)%\Microsoft Visual Studio\2017\Community\Common7\Tools\vsdevcmd" -arch=amd64 - - cmake -S . -B build -DEVMONE_TESTING=ON -DNATIVE=ON -Wno-dev -G "%GENERATOR%" -DCMAKE_INSTALL_PREFIX=C:\install + - cmake -S . -B build -DEVMONE_TESTING=ON -Wno-dev -G "%GENERATOR%" -DCMAKE_INSTALL_PREFIX=C:\install build_script: - cmake --build build --target package From a3195c9215f2b4d310d6da7368cc2d799b1d2dd0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Bylica?= Date: Wed, 1 Apr 2020 10:00:23 +0200 Subject: [PATCH 2/3] ci: Store Windows package as AppVeyor artifact --- appveyor.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/appveyor.yml b/appveyor.yml index 3e16e05658..13a998a774 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -33,6 +33,10 @@ build_script: - mkdir package - mv build/evmone-* package +artifacts: + - path: package/* + name: package + test_script: - cd build && ctest -j4 --output-on-failure --schedule-random From 629845f03e660403698836fc650ae362922b84b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Bylica?= Date: Wed, 1 Apr 2020 10:21:38 +0200 Subject: [PATCH 3/3] changelog: Add entry about Windows release binaries without AVX --- CHANGELOG.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9825fb036c..59bc545c92 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,15 @@ The format is based on [Keep a Changelog], and this project adheres to [Semantic Versioning]. +## [0.4.1] — unreleased + +### Fixed + +- The release binaries for Windows are now built without AVX instruction set + enabled. That was never intended and is consistent with binaries for other + operating systems. + [#230](https://github.com/ethereum/evmone/pull/230) + ## [0.4.0] — 2019-12-09 ### Fixed