Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-C: consider renaming block and tx level query keys #94

Closed
axic opened this issue Sep 1, 2016 · 4 comments
Closed

EVM-C: consider renaming block and tx level query keys #94

axic opened this issue Sep 1, 2016 · 4 comments
Assignees

Comments

@axic
Copy link
Member

axic commented Sep 1, 2016

Especially GAS_LIMIT as that is block level and hopefully there'll be a transaction level gas limit opcode in the future.

In eWASM we have every key prefixed.

@chfast
Copy link
Member

chfast commented Sep 1, 2016

I directly mapped the names from opcodes names, but that make sense.

@chfast
Copy link
Member

chfast commented Sep 14, 2016

@axic Do you want me to do it?

@axic
Copy link
Member Author

axic commented Sep 14, 2016

@chfast I can look into it during my flights or next week

@axic
Copy link
Member Author

axic commented May 24, 2017

This was done as part of #112.

@axic axic closed this as completed May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants