Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename evmc_uint256be to evmc_bytes32 to reflect its content better #121

Closed
axic opened this issue Aug 31, 2018 · 2 comments · Fixed by #152
Closed

Rename evmc_uint256be to evmc_bytes32 to reflect its content better #121

axic opened this issue Aug 31, 2018 · 2 comments · Fixed by #152

Comments

@axic
Copy link
Member

axic commented Aug 31, 2018 •
edited
Loading

This of course means for price values evmc_uint256be needs to be added back, but storage_set/storage_get/hashes evmc_bytes32 would be used.
@chfast
Copy link
Member

chfast commented Aug 31, 2018 •
edited
Loading

I like it.

We can add alias uint256be for bytes32 for special cases as value and difficulty.

@axic
Copy link
Member Author

axic commented Sep 5, 2018

@chfast @gumb0 suggested to use typedef. Need to check if rust-bindgen likes that.

@chfast chfast mentioned this issue Sep 6, 2018
Merged
@axic axic closed this as completed in #152 Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename uint256be to bytes32 ethereum/evmc
2 participants
@axic @chfast