Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing last-call-deadline should not create an annotation #69

Open
Pandapip1 opened this issue Mar 23, 2023 · 2 comments
Open

Missing last-call-deadline should not create an annotation #69

Pandapip1 opened this issue Mar 23, 2023 · 2 comments
Labels
in discussion Feature is still in discussion and should not be implemented

Comments

@Pandapip1
Copy link
Member

This is automagically assigned by the review bot now, meaning that a missing last call deadline should block the PR, but shouldn't display an annotation.
@SamWilsn SamWilsn added the in discussion Feature is still in discussion and should not be implemented label Apr 15, 2023
@SamWilsn
Copy link
Contributor

SamWilsn commented Apr 15, 2023 •
edited
Loading

Just to confirm what you want here, should eipw return a zero exit code (indicating success) or a non-zero exit code (indicating failure) when last-call-deadline is missing?

@Pandapip1
Copy link
Member Author

I would like it to fail, but to create either an info-type annotation or no annotation whatsoever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in discussion Feature is still in discussion and should not be implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pandapip1 @SamWilsn