Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node discovery and cademlia should use hash of public key as address #8

Closed
zelig opened this issue Feb 14, 2015 · 3 comments
Closed

Node discovery and cademlia should use hash of public key as address #8

zelig opened this issue Feb 14, 2015 · 3 comments

Comments

@zelig
Copy link

zelig commented Feb 14, 2015

Since no independent bits assumption is guaranteed on EC public keys
peers' public key needs to be hashed to derive a node's address used in cademlia routing.
Also, in order to help storage persistence of address-driven dht nodes the address should be derived from a permanent public key not an autogenerated one.
@zelig
Copy link
Author

zelig commented Feb 15, 2015

please review ethereum/go-ethereum#312

@subtly
Copy link
Member

subtly commented Feb 16, 2015

Fixed in 562e51c

@subtly subtly closed this as completed Feb 16, 2015
@subtly
Copy link
Member

subtly commented Feb 16, 2015

See also issue #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zelig @subtly