Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing bellatrix random test-gen #2813

Closed
protolambda opened this issue Jan 23, 2022 · 3 comments · Fixed by #2821
Closed

Missing bellatrix random test-gen #2813

protolambda opened this issue Jan 23, 2022 · 3 comments · Fixed by #2821

Comments

@protolambda
Copy link
Contributor

The random blocks test-generator is not running for bellatrix:

altair_mods = {key: 'eth2spec.test.altair.random.test_' + key for key in [

Verified they are missing in spec tests of v1.1.8

Shall I make a PR to enable this test-generator for bellatrix, or was it not enabled intentionally?

@djrtwo
Copy link
Contributor

djrtwo commented Jan 25, 2022

I believe this was unintentional. enabling for the release coming in next few days would be excellent 👍

@protolambda
Copy link
Contributor Author

So unlike other test types, the test-cases are specific to a single phase, and generated with code. Can't just update the main.py to enable the tests for bellatrix.

Looks like we need to update the code-generator with Bellatrix support, somewhere here:

@ralexstokes can you help here?

@ralexstokes
Copy link
Member

it is pretty straightforward to test the "default" case but the test logic will need to be extended to start testing "interesting" merge scenarios which this suite of tests would be well-positioned to address... i'd want to circle around with a few other efforts to understand the latest on merge testing before i dive into building these out

i'll open a PR with the "default" tests enabled and can extend in a future PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants