Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python bindings' load_trusted_setup() segfaults if file does not exist #400

Closed
alexhooketh opened this issue Mar 2, 2024 · 1 comment · Fixed by #401
Closed

Python bindings' load_trusted_setup() segfaults if file does not exist #400

alexhooketh opened this issue Mar 2, 2024 · 1 comment · Fixed by #401

Comments

@alexhooketh
Copy link 

jordan@MacBook-Air-Alex python % python3
Python 3.11.7 (main, Dec  4 2023, 18:10:11) [Clang 15.0.0 (clang-1500.1.0.2.5)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import ckzg
>>> ckzg.load_trusted_setup("sfsfdsfdsfdsf.json") # does not exist
zsh: segmentation fault  python3
jordan@MacBook-Air-Alex python %

Probably related to missing error checks on fopen, I'm not a C dev so can't really say for sure
@jtraglia jtraglia mentioned this issue Mar 2, 2024
Merged
@jtraglia
Copy link
Member

jtraglia commented Mar 2, 2024

@alexhooketh Thank you for reporting this! Definitely an oversight of ours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

python: check file pointer when loading trusted setup jtraglia/c-kzg-4844
2 participants
@jtraglia @alexhooketh