From d4f8eef2b093d6bacf972b7395de67c842dfe64d Mon Sep 17 00:00:00 2001 From: Liam Horne Date: Fri, 11 Jun 2021 14:25:11 -0400 Subject: [PATCH 1/2] refactor: log idx of monotonicity violation from batch --- .../src/batch-submitter/tx-batch-submitter.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/batch-submitter/src/batch-submitter/tx-batch-submitter.ts b/packages/batch-submitter/src/batch-submitter/tx-batch-submitter.ts index 7515b1028b62..ff7449b730c3 100644 --- a/packages/batch-submitter/src/batch-submitter/tx-batch-submitter.ts +++ b/packages/batch-submitter/src/batch-submitter/tx-batch-submitter.ts @@ -356,13 +356,17 @@ export class TransactionBatchSubmitter extends BatchSubmitter { // Verify all of the batch elements are monotonic let lastTimestamp: number let lastBlockNumber: number - for (const ele of batch) { + for (const [idx, ele] of batch.entries()) { if (ele.timestamp < lastTimestamp) { - this.logger.error('Timestamp monotonicity violated! Element', { ele }) + this.logger.error('Timestamp monotonicity violated! Element', { + idx, + ele, + }) return false } if (ele.blockNumber < lastBlockNumber) { this.logger.error('Block Number monotonicity violated! Element', { + idx, ele, }) return false From fe9de4e617cab5a6bd50e26104f82f8bbc14b808 Mon Sep 17 00:00:00 2001 From: Liam Horne Date: Fri, 11 Jun 2021 14:25:42 -0400 Subject: [PATCH 2/2] build: add changeset --- .changeset/weak-terms-worry.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/weak-terms-worry.md diff --git a/.changeset/weak-terms-worry.md b/.changeset/weak-terms-worry.md new file mode 100644 index 000000000000..dd9653d4c69a --- /dev/null +++ b/.changeset/weak-terms-worry.md @@ -0,0 +1,5 @@ +--- +'@eth-optimism/batch-submitter': patch +--- + +Log additional data in monotonicity violation