Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Geth to produce revert reasoning instead of UNPREDICTABLE_GAS_LIMIT #773

Closed
transmissions11 opened this issue May 5, 2021 · 4 comments · Fixed by #774
Closed

Comments

@transmissions11
Copy link
Contributor

transmissions11 commented May 5, 2021

Currently if a transaction reverts geth reports this error:
image
This makes it impossible to write tests that assert about revert reasons and is overall a big devex pain.

After talking with @smartcontracts, he said that updating Geth to use it's newer revert handling would fix this issue.

Here's what that updated error handling looks like:
https://github.com/ethereum/go-ethereum/blob/37b5595456e7049e3ed487c41564281de52e00ab/internal/ethapi/api.go#L1048-L1063

Here's the current error handling:
https://github.com/ethereum-optimism/go-ethereum/blob/beed9003d2f191befa91dde2a50f421c986bdc21/internal/ethapi/api.go#L1087-L1091

@transmissions11 transmissions11 changed the title Update Geth to produce revert reasoning instead of UNPREDICTABLE_GAS_USAGE Update Geth to produce revert reasoning instead of UNPREDICTABLE_GAS_LIMIT May 5, 2021
@transmissions11
Copy link
Contributor Author

fyi this is not fixed by v0.3-rc :)

@platocrat
Copy link
Contributor

@TransmissionsDev This looks like a duplicate of #664.

@K-Ho
Copy link
Contributor

K-Ho commented May 6, 2021

@TransmissionsDev This looks like a duplicate of #664.

No, they're different issues. This is the issue that revert reasons don't appear when running estimateGas on a tx that will revert. #664 is that estimateGas reverts when the tx should actually succeed.

@smartcontracts
Copy link
Contributor

Closed by #774!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants