Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit message hashes as an index event parameter #1116

Closed
rajivpo opened this issue Jun 18, 2021 · 3 comments
Closed

Emit message hashes as an index event parameter #1116

rajivpo opened this issue Jun 18, 2021 · 3 comments
Labels
C-feature Category: features

Comments

@rajivpo
Copy link
Contributor

rajivpo commented Jun 18, 2021

Makes me realize that we should emit the msg hash as an indexed event param.

Originally posted by @smartcontracts in #1107 (comment)

@smartcontracts
Copy link
Contributor

For some context, these events should be bytes32 indexed msgHash instead of bytes32 msgHash. Will make finding the event much easier on the client-side:

event RelayedMessage(bytes32 msgHash);
event FailedRelayedMessage(bytes32 msgHash);

@smartcontracts
Copy link
Contributor

If anyone wants to tackle this, please target the regenesis/0.5.0 branch (any changes to contracts go into regenesis/X.X.X branches, regenesis/0.5.0 is the next one that will be deployed).

@smartcontracts
Copy link
Contributor

Fixed in OVM 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: features
Projects
None yet
Development

No branches or pull requests

2 participants