client/v2: remove unsafe json-iterator/reflect2

[chaochn47]

Fix #13434

In addition to the reasons listed in #13434, the libraries were introduced by #10667 and driven by kubernetes usage.

PTAL @liggitt

/cc @hexfusion

[liggitt]

looks like the library requires go1.17+

[hexfusion]

cc @lilic I believe you were working on go 1.17 bump?

[chaochn47]

xref. #13314 ^

[lilic]

Yes, let me open that PR. I was waiting for another go.mod related PR to merge and it seems it has.

[lilic]

Opened #13440.

[lilic]

The other PR that bumps go versions got merged.

[chaochn47]

go mod tidy as part of ./scripts/fix.sh removes the indirect ones..

[lilic]

Strange, it doesn't do that for me 🤔 Which version of go are you using locally?

[chaochn47]

yeah, I was using go 1.16. Updated the latest go.mod after upgrading to 1.17

[chaochn47]

Previous CI failed on 'bom' ref. https://github.com/etcd-io/etcd/runs/4079040518?check_suite_focus=true

Latest force commit fixed it and verified locally.

GOARCH=amd64 PASSES='bom dep' ./test.sh
Running with --race
Starting at: Tue Nov  9 19:15:51 UTC 2021

'bom' started at Tue Nov  9 19:15:51 UTC 2021
Checking bill of materials...
% cp go.sum go.sum.tmp
% cp go.mod go.mod.tmp
% (cd tools/mod && gobin -p -m --mod=readonly github.com/coreos/license-bill-of-materials)
% /home/chaochn/workplace/EKS-etcd/src/etcd/tools/mod/.gobincache/github.com/coreos/license-bill-of-materials/@v/v0.0.0-20190913234955-13baff47494e/license-bill-of-materials --override-file ./bill-of-materials.override.json go.etcd.io/etcd/api/v3/... go.etcd.io/etcd/pkg/v3/... go.etcd.io/etcd/raft/v3/... go.etcd.io/etcd/client/pkg/v3/... go.etcd.io/etcd/client/v2/... go.etcd.io/etcd/client/v3/... go.etcd.io/etcd/server/v3/... go.etcd.io/etcd/etcdutl/v3/... go.etcd.io/etcd/etcdctl/v3/... go.etcd.io/etcd/tests/v3/... go.etcd.io/etcd/v3/...
% cp go.sum.tmp go.sum
% cp go.mod.tmp go.mod
'bom' completed at Tue Nov  9 19:15:55 UTC 2021

'dep' started at Tue Nov  9 19:15:55 UTC 2021
% (cd api && go list -m)
% (cd api && go list -f {{if not .Indirect}}{{if .Version}}{{.Path}},{{.Version}},go.etcd.io/etcd/api/v3{{end}}{{end}} -m all)
% (cd pkg && go list -m)
% (cd pkg && go list -f {{if not .Indirect}}{{if .Version}}{{.Path}},{{.Version}},go.etcd.io/etcd/pkg/v3{{end}}{{end}} -m all)
% (cd raft && go list -m)
% (cd raft && go list -f {{if not .Indirect}}{{if .Version}}{{.Path}},{{.Version}},go.etcd.io/etcd/raft/v3{{end}}{{end}} -m all)
% (cd client/pkg && go list -m)
% (cd client/pkg && go list -f {{if not .Indirect}}{{if .Version}}{{.Path}},{{.Version}},go.etcd.io/etcd/client/pkg/v3{{end}}{{end}} -m all)
% (cd client/v2 && go list -m)
% (cd client/v2 && go list -f {{if not .Indirect}}{{if .Version}}{{.Path}},{{.Version}},go.etcd.io/etcd/client/v2{{end}}{{end}} -m all)
% (cd client/v3 && go list -m)
% (cd client/v3 && go list -f {{if not .Indirect}}{{if .Version}}{{.Path}},{{.Version}},go.etcd.io/etcd/client/v3{{end}}{{end}} -m all)
% (cd server && go list -m)
% (cd server && go list -f {{if not .Indirect}}{{if .Version}}{{.Path}},{{.Version}},go.etcd.io/etcd/server/v3{{end}}{{end}} -m all)
% (cd etcdutl && go list -m)
% (cd etcdutl && go list -f {{if not .Indirect}}{{if .Version}}{{.Path}},{{.Version}},go.etcd.io/etcd/etcdutl/v3{{end}}{{end}} -m all)
% (cd etcdctl && go list -m)
% (cd etcdctl && go list -f {{if not .Indirect}}{{if .Version}}{{.Path}},{{.Version}},go.etcd.io/etcd/etcdctl/v3{{end}}{{end}} -m all)
% (cd tests && go list -m)
% (cd tests && go list -f {{if not .Indirect}}{{if .Version}}{{.Path}},{{.Version}},go.etcd.io/etcd/tests/v3{{end}}{{end}} -m all)
% go list -m
% go list -f {{if not .Indirect}}{{if .Version}}{{.Path}},{{.Version}},go.etcd.io/etcd/v3{{end}}{{end}} -m all
SUCCESS: dependencies are consistent across modules
'dep' completed at Tue Nov  9 19:16:06 UTC 2021
SUCCESS

[hexfusion]

thanks @chaochn47 !