Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration: fix a data race about i and tt in TestV3WatchFromCur… #10901

Closed
wants to merge 0 commits into from
Closed

integration: fix a data race about i and tt in TestV3WatchFromCur… #10901

wants to merge 0 commits into from

Conversation

yuzeming
Copy link
Contributor

…rentRevision

don't references to loop variables from within go anonymous function

Fixes #10899

@jingyih
Copy link
Contributor

jingyih commented Jul 16, 2019

How about just waiting for the go routine to finish at the end of each loop?

@yuzeming
Copy link
Contributor Author

I updated my PR. Could you have look on my code? Thanks.

@jingyih
Copy link
Contributor

jingyih commented Jul 17, 2019

Could you squash the commits?

@yuzeming yuzeming closed this Jul 17, 2019
@yuzeming yuzeming deleted the fixed-10899 branch July 17, 2019 23:38
@yuzeming yuzeming restored the fixed-10899 branch July 17, 2019 23:38
@yuzeming
Copy link
Contributor Author

I made some mistakes and this PR was closed. I create a new PR here.
#10904

Sorry for this inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Dara Race in TestV3WatchFromCurrentRevision
2 participants