Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add flag to let etcd use the new boltdb freelistType feature #10444

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

WIZARD-CXY
Copy link
Contributor

@WIZARD-CXY WIZARD-CXY commented Feb 2, 2019

Use the new bboltdb feature(map freelist type) as a experimental feature in etcd to boost the performance when the data stored in etcd is huge(like 50GB).

@WIZARD-CXY
Copy link
Contributor Author

@xiang90 ptal

@codecov-io
Copy link

codecov-io commented Feb 2, 2019

Codecov Report

Merging #10444 into master will decrease coverage by 0.19%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #10444     +/-   ##
=========================================
- Coverage   71.67%   71.48%   -0.2%     
=========================================
  Files         392      392             
  Lines       36495    36504      +9     
=========================================
- Hits        26158    26095     -63     
- Misses       8517     8590     +73     
+ Partials     1820     1819      -1
Impacted Files Coverage Δ
etcdserver/config.go 79.51% <ø> (ø) ⬆️
etcdmain/config.go 82.48% <100%> (+0.08%) ⬆️
etcdserver/backend.go 52.83% <100%> (+0.9%) ⬆️
embed/etcd.go 71% <100%> (+0.11%) ⬆️
mvcc/backend/backend.go 74.15% <100%> (+0.09%) ⬆️
embed/config.go 56.37% <50%> (-0.08%) ⬇️
etcdctl/ctlv3/command/printer_simple.go 39.59% <0%> (-32.89%) ⬇️
etcdserver/api/v3rpc/util.go 43.47% <0%> (-26.09%) ⬇️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
pkg/adt/interval_tree.go 86.78% <0%> (-3.01%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24fc2a9...e6c6d84. Read the comment docs.

@WIZARD-CXY WIZARD-CXY force-pushed the nnboltdb branch 4 times, most recently from 290d846 to 95f6c7b Compare February 5, 2019 05:34
@WIZARD-CXY
Copy link
Contributor Author

WIZARD-CXY commented Feb 5, 2019

@xiang90 ptal

@xiang90
Copy link
Contributor

xiang90 commented Feb 7, 2019

/cc @jpbetz

@WIZARD-CXY WIZARD-CXY force-pushed the nnboltdb branch 3 times, most recently from b7c3383 to 7ab720b Compare February 8, 2019 13:11
@WIZARD-CXY
Copy link
Contributor Author

@xiang90 ptal

@xiang90
Copy link
Contributor

xiang90 commented Feb 12, 2019

lgtm after fixing the import line.

Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just few nits.

@WIZARD-CXY
Copy link
Contributor Author

WIZARD-CXY commented Feb 14, 2019

@xiang90 @jingyih changed according to your suggestions. ptal

@xiang90
Copy link
Contributor

xiang90 commented Feb 14, 2019

lgtm

@xiang90 xiang90 merged commit 4cd0bf8 into etcd-io:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants