-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: rename import paths to "go.etcd.io/etcd" #10044
Conversation
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
This reverts commit 299178c.
Proto gen has some issues with swagger doc... Will debug separate. Reverted the change for now. |
LGTM |
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
whats the effect on developers? |
You can just move git to |
Thanks @philips I'll update the above comment to match. |
Thanks @jpbetz for the detailed explanation and suggested fix. I think we should make this more visible to the etcd community. |
@jpbetz Thanks for the detailed explanation. This is exactly the issue I was having. I don't have a dependency on etcd master, so I can use a release version. Since we will eventually have to handle newer etcd releases, for now, I will move to go.etcd.io/etcd and give it a try. Thanks |
* Fix boltdb import -> go.etcd.io/bbolt * Fix etcd import -> go.etcd.io/etcd etcd-io/etcd#10044 (comment)
* Fix boltdb import -> go.etcd.io/bbolt * Fix etcd import -> go.etcd.io/etcd * Bumped underlying service versions in build * Bumped the golang version * Fix for golint etcd-io/etcd#10044 (comment)
why i import this package is this error? github.com/etcd-io/etcd/clientv3../src/github.com/etcd-io/etcd/clientv3/auth.go:116:72: cannot use auth.callOpts (type []"github.com/etcd-io/etcd/vendor/google.golang.org/grpc".CallOption) as type []"go.etcd.io/etcd/vendor/google.golang.org/grpc".CallOption in argument to auth.remote.AuthEnable |
i'm import this package "go.etcd.io/etcd/clientv3" is this panic error ? panic: /debug/requests is already registered. You may have two independent copies of golang.org/x/net/trace in your binary, trying to maintain separate state. This may involve a vendored copy of golang.org/x/net/trace. goroutine 1 [running]: |
The etcd project has switched from github.com URLs to go.etcd.io URLs. The import statements in distlock.go have been updated to reflect this. The old imports failed to compile. See here for details: etcd-io/etcd#10044 (comment)
* Fix boltdb import -> go.etcd.io/bbolt * Fix etcd import -> go.etcd.io/etcd * Bumped underlying service versions in build * Bumped the golang version * Fix for golint etcd-io/etcd#10044 (comment)
* Fix boltdb import -> go.etcd.io/bbolt * Fix etcd import -> go.etcd.io/etcd * Bumped underlying service versions in build * Bumped the golang version * Fix for golint etcd-io/etcd#10044 (comment)
* Fix boltdb import -> go.etcd.io/bbolt * Fix etcd import -> go.etcd.io/etcd * Bumped underlying service versions in build * Bumped the golang version * Fix for golint etcd-io/etcd#10044 (comment)
Fix #9965.
This only updates the necessary ones to wrap up our github org migration. Some still reference to
github.com/coreos/etcd
(e.g. v2 docs, old branches). Will change rest in the following PR.Note: this does not add canonical import paths (https://golang.org/doc/go1.4#canonicalimports), which I don't think is necessary--Kubernetes does not use it either.
/cc @philips @xiang90 @jpbetz