We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add links / instruction to install protoc for setting up the dev environment.
it should also mention that protoc needs to be version 3.20.3 https://github.com/etcd-io/etcd/blob/main/scripts/genproto.sh#L27
3.20.3
make verify fails in protoc is not available in the system or the version is anything other than 3.20.3
make verify
The text was updated successfully, but these errors were encountered:
I think it's to produce reproducible builds by pinning protoc generation to a specific version.
protoc
Source
if [[ $(protoc --version | cut -f2 -d' ') != "3.20.3" ]]; then echo "could not find protoc 3.20.3, is it installed + in PATH?" exit 255 fi
Sorry, something went wrong.
Thats reasonable. But the contributing.md does not mention protoc being a requirement. So when make verify is run it will fail the test.
contributing.md
Thanks for raising this @moficodes - I think it makes sense to add a bullet point under https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#option-1---manually-setup-local-environment to cover installing the projects pinned version of protoc. If you have time please raise a pr 🙏🏻
Please assign this to me.
There is also some other requirements for this that I can add to the same pr.
e.g - yamllint
Would be great enhancement to add a make install-protoc install-yamllint commands
make install-protoc install-yamllint
moficodes
No branches or pull requests
What would you like to be added?
add links / instruction to install protoc for setting up the dev environment.
it should also mention that protoc needs to be version
3.20.3
https://github.com/etcd-io/etcd/blob/main/scripts/genproto.sh#L27Why is this needed?
make verify
fails in protoc is not available in the system or the version is anything other than3.20.3
The text was updated successfully, but these errors were encountered: