From c18010cf42f265cb247f924c54bf157f08a17626 Mon Sep 17 00:00:00 2001 From: Piotr Tabor Date: Fri, 14 May 2021 06:16:36 +0200 Subject: [PATCH] etcdproxy e2e tests should run in dedicated directories. So far all proxies were sharing the same (current) directory, leading to tests flakes, e.g. due to certificates being overriden in autoTLS mode. --- tests/e2e/cluster_proxy_test.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/e2e/cluster_proxy_test.go b/tests/e2e/cluster_proxy_test.go index 47ac18f9692..b96a10037fd 100644 --- a/tests/e2e/cluster_proxy_test.go +++ b/tests/e2e/cluster_proxy_test.go @@ -186,21 +186,23 @@ func proxyListenURL(cfg *etcdServerProcessConfig, portOffset int) string { func newProxyV2Proc(cfg *etcdServerProcessConfig) *proxyV2Proc { listenAddr := proxyListenURL(cfg, 2) name := fmt.Sprintf("testname-proxy-%p", cfg) + dataDir := path.Join(cfg.dataDirPath, name+".etcd") args := []string{ "--name", name, "--proxy", "on", "--listen-client-urls", listenAddr, "--initial-cluster", cfg.name + "=" + cfg.purl.String(), + "--data-dir", dataDir, } return &proxyV2Proc{ - proxyProc{ + proxyProc: proxyProc{ lg: cfg.lg, execPath: cfg.execPath, args: append(args, cfg.tlsArgs...), ep: listenAddr, donec: make(chan struct{}), }, - name + ".etcd", + dataDir: dataDir, } } @@ -242,6 +244,7 @@ func newProxyV3Proc(cfg *etcdServerProcessConfig) *proxyV3Proc { "--endpoints", cfg.acurl, // pass-through member RPCs "--advertise-client-url", "", + "--data-dir", cfg.dataDirPath, } murl := "" if cfg.murl != "" {