Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GOMEMLIMIT instead of GOGC to limit GitHub test workflow memory #609

Closed
ivanvc opened this issue Nov 14, 2023 · 2 comments · Fixed by #612
Closed

Use GOMEMLIMIT instead of GOGC to limit GitHub test workflow memory #609

ivanvc opened this issue Nov 14, 2023 · 2 comments · Fixed by #612
Assignees
@ivanvc

Comments

@ivanvc
Copy link
Member

ivanvc commented Nov 14, 2023

Currently, the tests GitHub workflow has a comment to switch to GOMEMLIMIT from GOGC once the project uses a greater version than Go 1.19 (https://github.com/etcd-io/bbolt/blob/master/.github/workflows/tests-template.yml#L45-L50). The current Go version is now 1.21, but the command was never updated to use GOMEMLIMIT.
@ivanvc
Copy link
Member Author

ivanvc commented Nov 14, 2023

Can you assign me to this issue? Thanks.

@jmhbnz
Copy link
Member

jmhbnz commented Nov 15, 2023

Assigned - good spotting @ivanvc!

This was referenced Nov 15, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanvc ivanvc

Labels
None yet
Milestone
No milestone
2 participants
@ivanvc @jmhbnz