-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[request] Support cred helpers in the mplatform/manifest-tool container #216
Comments
Instead of adding them add tools to the docker image, wouldn't it be possible to import most of them directly? Most helpers are written in go. See the way kaniko does it for example. |
That was my point in 207, kaniko implements the cred helpers using go modules so they become part of the binary and it would be awesome if manifest-tool does the same. To be fair, they also distribute the cred helpers alongside the kaniko |
It would be great if cred helpers could be added to the base image. |
I opened #230 to add the binary cred helpers to the alpine image. Need to add some instructions on how to use them with the image. Any feedback if users will want them in the static image as well? My initial idea was to keep that image as small as possible, but I know it is the default when using the |
For now, as of v2.1.3 today, the |
Per #207, there is a more general issue that the cred helper binaries are not installed in either of the
manifest-tool
container images. This issue will be used to discuss and work on adding the cred helpers to either an existing image or a new image (TBD, thoughts?)In the interim, or at least until the next release, we can at least provide a contributed
Dockerfile
that builds a downstream image that supports cred helpers with instructions.The text was updated successfully, but these errors were encountered: