Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Windows build node in ESS builds #570

Closed
amues opened this issue Jan 24, 2022 · 1 comment
Closed

Drop Windows build node in ESS builds #570

amues opened this issue Jan 24, 2022 · 1 comment

Comments

@amues
Copy link
Contributor

amues commented Jan 24, 2022

@eugenwintersberger @jkotan, as Windows builds are being added in GitHub CI as part of #501, we are evaluating the possibility dropping the Windows builds from the ESS Jenkins builds.

We don't use Windows internally, so we don't consider the effort it takes to maintain the Windows 10 build node is worth it, as that is the only Windows server we run in our CI infrastructure.

Do the new GitHub CI Windows builds cover the project's needs? What is your opinion on dropping the ESS Windows build?

@jkotan
Copy link
Collaborator

jkotan commented Jan 24, 2022

Hello @amues,
at DESY/PETRAIII we try to avoid Windows but it is not always possible (because of vendor drivers). I think for us it is enough to it is enough to run Windows tests on github nodes and skip ESS Windows tests runs.
Then it would be good

  1. to extend github tests to all branches (currently they are run only on master branches)
  2. to fix the issue in Cmake improvements #501 PR. Currently some windows tests are not launched
Run cd build
UpdateCTestConfiguration  from :D:/a/h5cpp/h5cpp/build/DartConfiguration.tcl
UpdateCTestConfiguration  from :D:/a/h5cpp/h5cpp/build/DartConfiguration.tcl
Test project D:/a/h5cpp/h5cpp/build
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
No tests were found!!!

https://github.com/ess-dmsc/h5cpp/runs/4907883392?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants