Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In FlashArgs, monitor_args requires monitorarg, but clap does not support requires with flatten #764

Open
SergioGasquez opened this issue Feb 12, 2025 · 1 comment
Open

In FlashArgs, monitor_args requires monitorarg, but clap does not support requires with flatten #764

SergioGasquez opened this issue Feb 12, 2025 · 1 comment
Labels
CLI Issues relating to the command-line interface
Milestone
v4

Comments

@SergioGasquez
Copy link
Member

See https://github.com/esp-rs/espflash/pull/737/files#r1937149668
@SergioGasquez SergioGasquez added the CLI Issues relating to the command-line interface label Feb 12, 2025
@SergioGasquez SergioGasquez changed the title In FlashArgs monitor_args requires monitorarg, but clap does not support requires with flatten In FlashArgs, monitor_args requires monitorarg, but clap does not support requires with flatten Feb 12, 2025
This was referenced Feb 12, 2025
Merged
Merged
@SergioGasquez
Copy link
Member Author

We should also investigate if there is a better way to check that elf is provided if using log-format in the monitoring subcommand and to now allow something like flash --monitor target/.../elf --elf target/.../elf. See #759 (comment)

@jessebraham jessebraham added this to the v4 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CLI Issues relating to the command-line interface
Projects
esp-rs
Status: Todo
Milestone
v4
Development

No branches or pull requests
2 participants
@jessebraham @SergioGasquez