-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Rework configuration methods #507
Comments
I'll list some pros and cons about each method:
|
I never used package metadata (since I never use cargo-espflash) or global config file (didn't knew that exists) but I use env variables for a few things a lot! e.g. my use-case is I have a few boards attaches, have a terminal open for working with each of them and set I don't think we should use env vars as a general config mechanism but for the things we currently support we should definitely keep them. e.g. I have seen people committing their working baud rate (or even serial port) to In general, those two env vars are also not really config but an alternative way to specify something which is usually given as a command line parameter (we even use a clap feature for that) TL;DR I don't care much about any config files since I don't use them but please, please, please keep the env vars |
I use package metata useful in my daily development workflow, specifically the While I don't currently use environment variables, I can see how they could be quite convenient. |
Relevant link: configuration file of |
At the moment we have several ways of configuring
esplfash/cargo-espflash
behavior:cargo-espflash
)ESPFLASH_BAUD
andESPFLASH_PORT
The idea would be to simplify and integrate most of this configuration options into a single one.
Related issues: #504, #469
The text was updated successfully, but these errors were encountered: