Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event-Loop async subscription #474

Closed
mineiwik opened this issue Aug 24, 2024 · 1 comment
Closed

Event-Loop async subscription #474

mineiwik opened this issue Aug 24, 2024 · 1 comment

Comments

@mineiwik
Copy link

When one subscribes asynchronously to a custom event using the subscribe_async function, it listens to all events happening on the given event-loop, instead of limiting to the given event(s). I think the problem is that in the subscribe_async implementation, the EspEvent struct is supplied as the generic type for the subscribe call, which by default listens to all events. Shouldn't that use the given D generic that holds the event one has specified?

@mineiwik
Copy link
Author

I just tested using the main branch and there it works just fine. It has already been addressed in #466.

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant