Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inherent set_interrupt_handler method to drivers #2905

Closed
MabezDev opened this issue Jan 8, 2025 · 2 comments · Fixed by #2944
Closed

Add inherent set_interrupt_handler method to drivers #2905

MabezDev opened this issue Jan 8, 2025 · 2 comments · Fixed by #2944
Assignees
@JurajSadel
Labels
1.0 non-breaking Not needed for 1.0 and can be supported without breaking the driver. api
Milestone
0.23.0

Comments

@MabezDev
Copy link
Member

MabezDev commented Jan 8, 2025

We currently only implement the trait, which isn't be stabilized. We have also discussed removing the trait as it's not used in many places.

At the very least for all stable drivers, there should be an inherent set_interrupt_handler method.
@MabezDev MabezDev added this to the 1.0.0-beta.0 milestone Jan 8, 2025
@github-project-automation github-project-automation bot moved this to Todo in esp-rs Jan 8, 2025
@MabezDev MabezDev mentioned this issue Jan 8, 2025
Open
@bugadani
Copy link
Contributor

bugadani commented Jan 8, 2025

This needs a corresponding listen, unlisten, clear_interrupts, pending as well, otherwise users can configure the handler, but can't do anything with them :)

@JurajSadel JurajSadel self-assigned this Jan 8, 2025
This was referenced Jan 10, 2025
Closed
Merged
@MabezDev
Copy link
Member Author

MabezDev commented Jan 10, 2025 •
edited
Loading

As per #2900 (comment) I'm removing the 1.0 blocker, but I'll keep it in the milestone as this is something we should do regardless (and it's in progress).

@MabezDev MabezDev added 1.0 non-breaking Not needed for 1.0 and can be supported without breaking the driver. and removed 1.0-blocker labels Jan 10, 2025
@JurajSadel JurajSadel mentioned this issue Jan 13, 2025
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Jan 14, 2025
This was referenced Jan 16, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JurajSadel JurajSadel

Labels
1.0 non-breaking Not needed for 1.0 and can be supported without breaking the driver. api
Projects
esp-rs
Archived in project
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

i2c_master: Add interrupt APIs JurajSadel/esp-hal
3 participants
@bugadani @MabezDev @JurajSadel