Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPIO Pin Hold is not supported #2705

Open
Tracked by #2492
bugadani opened this issue Dec 9, 2024 · 2 comments
Open
Tracked by #2492

GPIO Pin Hold is not supported #2705

bugadani opened this issue Dec 9, 2024 · 2 comments
Labels
1.0 non-breaking Not needed for 1.0 and can be supported without breaking the driver. peripheral:gpio GPIO peripheral

Comments

@bugadani
Copy link
Contributor

bugadani commented Dec 9, 2024

No description provided.

@bugadani bugadani mentioned this issue Dec 9, 2024
34 tasks
@github-project-automation github-project-automation bot moved this to Todo in esp-rs Dec 9, 2024
@tom-borcin tom-borcin added the investigation Not needed for 1.0, but don't know if we can support without breaking the driver. label Dec 18, 2024
@bjoernQ
Copy link
Contributor

bjoernQ commented Dec 19, 2024

For S3 (looks like most? others)

image

For C6

image

While I can imagine to have a FrozenPin driver (name is subject to bike-shedding) the

  • Or users can set PMU_TIE_HIGH_HP_PAD_HOLD_ALL to maintain the input/output status of all
    digital pins
  • Or users can set PMU_TIE_HIGH_LP_PAD_HOLD_ALL to hold the values of all LP pins, and set
    PMU_TIE_LOW_LP_PAD_HOLD_ALL to disable the hold function of all LP pins.

part makes things a bit more complex, but I still think supporting this in future can be done in a non-breaking way

@MabezDev
Copy link
Member

MabezDev commented Jan 9, 2025

While I can imagine to have a FrozenPin driver (name is subject to bike-shedding) the

an alternative to a separate driver would be to have a fn hold(self) on the Output driver. We may also want to add a result fn hold(self) -> Result<(), Error> if not all pins can support the hold function.

Regardless, we can add this post 1.0 at any time.

@MabezDev MabezDev added 1.0 non-breaking Not needed for 1.0 and can be supported without breaking the driver. and removed 1.0-blocker investigation Not needed for 1.0, but don't know if we can support without breaking the driver. labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 non-breaking Not needed for 1.0 and can be supported without breaking the driver. peripheral:gpio GPIO peripheral
Projects
Status: Todo
Development

No branches or pull requests

4 participants