Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other clock sources in timer driver #174

Closed
JurajSadel opened this issue Aug 30, 2022 · 2 comments
Closed

Add support for other clock sources in timer driver #174

JurajSadel opened this issue Aug 30, 2022 · 2 comments

Comments

@JurajSadel
Copy link
Contributor

Currently, we are using only apb_clock in General-purpose timers implementation. The #77 added other options for the clock source.

@JurajSadel JurajSadel self-assigned this Aug 30, 2022
@JurajSadel JurajSadel moved this to Todo in esp-rs Aug 30, 2022
@JurajSadel JurajSadel moved this from Todo to In Progress in esp-rs Aug 30, 2022
@JurajSadel
Copy link
Contributor Author

After discussion with @bjoernQ it seems it's not that straightforward.

In ESP-IDF the user can set the clock source but also manually choose the divider etc - it's a much lower level API.
Do we want to have an additional low-level constructor that takes the clock source and divider? Then the user will want to use ticks for e.g start function - probably going to be a lot of effort.
Also would be a general design decision since if we offer a low-level version here why don't we have it everywhere?

For now, let's turn this issue into a discussion of how we want to deal with this in the future.
What is your opinion @bjoernQ, @jessebraham, @MabezDev?

@MabezDev
Copy link
Member

ABP has served us well and I'm not aware of any current issues with TIMG being driven from it, therefore I'm going to close this for now.

@github-project-automation github-project-automation bot moved this from In Progress to Done in esp-rs Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants