Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly redundant delay in Rtc::sleep #1082

Closed
dimpolo opened this issue Jan 15, 2024 · 1 comment · Fixed by #1794
Closed

Possibly redundant delay in Rtc::sleep #1082

dimpolo opened this issue Jan 15, 2024 · 1 comment · Fixed by #1794
Assignees
Labels
status:needs-attention This should be prioritized

Comments

@dimpolo
Copy link
Contributor

dimpolo commented Jan 15, 2024

I'm unclear about the purpose of the 100ms delay before going to sleep here:

https://github.com/liebman/esp-hal/blob/2e2d67f315d7c3abf0d023fda541473858769965/esp-hal-common/src/rtc_cntl/mod.rs#L319C32-L319C32

@liebman suggested it might have been left in by mistake #574 (comment)

If so, we should remove the delay parameter of the various sleep methods

@bjoernQ
Copy link
Contributor

bjoernQ commented Jan 15, 2024

We should probably double check with code in esp-idf - if they don't have that and everything works without we probably can/should remove it

@jessebraham jessebraham added the status:needs-attention This should be prioritized label Jul 8, 2024
@SergioGasquez SergioGasquez self-assigned this Jul 15, 2024
@SergioGasquez SergioGasquez linked a pull request Jul 15, 2024 that will close this issue
5 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:needs-attention This should be prioritized
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants