-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runArgs allowing for flashing from devcontainer #105
Comments
I would prefer adding it without an extra option, just include it by default. The thing is, this only works for linux and maybe macos, rigth? |
Seems so. This will add functionality only for linux hosts, but should not break builds for mac/win. |
I guess we could add the snippet with some comments if it's not harmful for other OSs, something like: # This only works for Linux devices and requires updating the `device` field
"runArgs": [
"--privileged",
"--device=/dev/ttyACM0",
"--group-add=dialout"
], |
Checked on win10, running docker desktop. Builds just fine. Don't see why on mac would be different. LGTM! |
Hi,
Thanks for this tool! I really like that it also prepares devcontainer config.
Have you considered adding:
As an option in TUI? So flashing directly from devcontainer would be possible out of the box.
The text was updated successfully, but these errors were encountered: