Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runArgs allowing for flashing from devcontainer #105

Closed
legas7 opened this issue Feb 10, 2025 · 4 comments · Fixed by #114
Closed

Add runArgs allowing for flashing from devcontainer #105

legas7 opened this issue Feb 10, 2025 · 4 comments · Fixed by #114

Comments

@legas7
Copy link
Contributor

legas7 commented Feb 10, 2025

Hi,

Thanks for this tool! I really like that it also prepares devcontainer config.

Have you considered adding:

  "runArgs": [
    "--privileged",
    "--device=/dev/ttyACM0",
    "--group-add=dialout"
  ],

As an option in TUI? So flashing directly from devcontainer would be possible out of the box.

@SergioGasquez
Copy link
Member

As an option in TUI?

I would prefer adding it without an extra option, just include it by default. The thing is, this only works for linux and maybe macos, rigth?

@legas7
Copy link
Contributor Author

legas7 commented Feb 11, 2025

The thing is, this only works for linux and maybe macos, rigth?

Seems so. This will add functionality only for linux hosts, but should not break builds for mac/win.

@SergioGasquez
Copy link
Member

This will add functionality only for linux hosts, but should not break builds for mac/win.

I guess we could add the snippet with some comments if it's not harmful for other OSs, something like:

  # This only works for Linux devices and requires updating the `device` field
  "runArgs": [
    "--privileged",
    "--device=/dev/ttyACM0",
    "--group-add=dialout"
  ],

@legas7
Copy link
Contributor Author

legas7 commented Feb 12, 2025

Checked on win10, running docker desktop. Builds just fine. Don't see why on mac would be different. LGTM!

@SergioGasquez SergioGasquez linked a pull request Feb 13, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants