Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace deprecated isSpaceBetweenTokens with isSpaceBetween #646

Merged
merged 3 commits into from
Dec 21, 2024

Conversation

9romise
Copy link
Member

@9romise 9romise commented Dec 21, 2024

Description

isSpaceBetweenTokens has been deprecated in ESLint v6.7.0 in eslint/eslint#12519.

But it has changed the behavior of the isSpaceBetweenTokens() method about JSXText tokens that contain only spaces.

Linked Issues

Related to:

Additional context

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.94%. Comparing base (33ae1f6) to head (76f5c1a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...t-plugin/rules/comma-spacing/comma-spacing._js_.ts 0.00% 2 Missing ⚠️
...ugin/rules/space-infix-ops/space-infix-ops._js_.ts 33.33% 2 Missing ⚠️
...function-paren/space-before-function-paren._js_.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #646   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files         121      121           
  Lines       20353    20355    +2     
  Branches     4833     4835    +2     
=======================================
+ Hits        19732    19734    +2     
  Misses        618      618           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antfu antfu added this pull request to the merge queue Dec 21, 2024
Merged via the queue into eslint-stylistic:main with commit 6da7c42 Dec 21, 2024
10 of 11 checks passed
@9romise 9romise deleted the refactor/is-space-between branch December 22, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants