From 4d8c8999f1cc8df6fbba9f496d2ea183f8c46ae1 Mon Sep 17 00:00:00 2001 From: Jeff Wolski Date: Fri, 28 Aug 2015 16:51:27 +0200 Subject: [PATCH] Ben's feedback; config updated -> set --- config.js | 4 ++-- test/unit/config_test.js | 16 ++++++---------- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/config.js b/config.js index cadc85bb..635d830c 100644 --- a/config.js +++ b/config.js @@ -40,8 +40,8 @@ Config.prototype.get = function get(key) { Config.prototype.set = function set(key, value) { var oldValue = this.store[key]; this.store[key] = value; - this.emit('changed', key, value, oldValue); - this.emit('changed.' + key, value, oldValue); + this.emit('set', key, value, oldValue); + this.emit('set.' + key, value, oldValue); }; Config.prototype._seed = function _seed(seed) { diff --git a/test/unit/config_test.js b/test/unit/config_test.js index 55d85ade..55eb1a1a 100644 --- a/test/unit/config_test.js +++ b/test/unit/config_test.js @@ -37,21 +37,17 @@ test('changed events', function t(assert) { assert.plan(2); var config = new Config(); - config.on('changed', onConfigChanged); + config.on('set', function onSet() { + assert.pass('set'); + }); var configKey = 'somekey'; - config.on('changed.' + configKey, onConfigKeyChanged); + config.on('set.' + configKey, function onKeySet() { + assert.pass('key set'); + }); var configVal = 'someval'; config.set(configKey, configVal); // this triggers change events *fingers crossed* assert.end(); - - function onConfigChanged() { - assert.pass('changed'); - } - - function onConfigKeyChanged() { - assert.pass('key changed'); - } }); test('seeds known config', function t(assert) {