Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with PHP 8.0 and lower #369

Closed
mvorisek opened this issue Nov 19, 2023 · 2 comments
Closed

Compatibility with PHP 8.0 and lower #369

mvorisek opened this issue Nov 19, 2023 · 2 comments
Assignees

Comments

@mvorisek
Copy link
Contributor

#341 added phpunit 9.x support but it was releases after the compatibility with older PHP versions was dropped in #87 and #171.

In order to fully benefit from #341 and to allow this dependency in projects with PHP 8.1- support, the PHP version requirement must be lowered.

The latest johnkary/phpunit-speedtrap, at the time of writing this, requires PHP 7.2+ support - https://github.com/johnkary/phpunit-speedtrap/blob/master/composer.json#L22 so reintroducing support since this version would be welcomed to allow this package to be a real replacement.

Once the support for older PHP versions is added and at least one version tagged, the support for older PHP versions can be then removed again.

How to reproduce:

  1. add ergebnis/phpunit-slow-test-detector dependency to a PHP 7.4 - 8.3 project
  2. run composer update on/using PHP 7.4 platform
@localheinz
Copy link
Member

Fixed with #375 and #390.

@localheinz
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants