New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoEmptyRule is redundant #524

Closed

enumag opened this issue Apr 20, 2023 · 1 comment · Fixed by #525

Contributor

enumag commented Apr 20, 2023 •

edited

Loading

This package is recommended to be used on top of phpstan/phpstan-strict-rules which already has a DisallowedEmptyRule. As such I think the NoEmptyRule should be removed from this package.

I can send a pull request if you agree.

Member

localheinz commented Apr 20, 2023

I would appreciate it, @enumag!

enumag mentioned this issue

Remove redundant NoEmptyRule #525

Merged

localheinz closed this as completed in #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment