Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect classification for low-variance data #35

Closed
kohlert opened this issue Aug 28, 2024 · 2 comments
Closed

Incorrect classification for low-variance data #35

kohlert opened this issue Aug 28, 2024 · 2 comments

Comments

@kohlert
Copy link
Contributor

kohlert commented Aug 28, 2024

I often work with timeseries data in log space, and it can have a fairly small absolute variance. I believe the fix for issue #26 has since caused another bug where the added random noise (up to 0.1, based on the distribution used) can be sufficient to introduce significant errors into the resulting peak detection.

image

The ideal solution would probably be to use indexing instead of relying on unique values for de-duplication, but that might require some additional refactoring that I haven't fully scoped out.

A simple alternative solution could be to use the smallest available increment to de-duplicate the data instead of relying on random noise.

@erdogant
Copy link
Owner

Thank you for this contribution! Your solution is much better than adding random noise. I created a new version.

@kohlert
Copy link
Contributor Author

kohlert commented Aug 28, 2024

Glad I could help out. Thanks for all the work you do on the library. This is a great resource!

@kohlert kohlert closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants