fix: well layer: wellNameAtTop control is inverted #2432 #2433
Conversation
nilscb
commented
Feb 3, 2025
nilscb
commented
- Simplified some code
- Make sure label stays visible when camera changes.
- fix bug "well layer: wellNameAtTop control is inverted well layer: wellNameAtTop control is inverted #2432"
nilscb
added
bug
typescript/packages/subsurface-viewer/src/storybook/layers/WellsLayer.stories.tsx
Outdated
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/storybook/layers/WellsLayer.stories.tsx
Outdated
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts
Outdated
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts
Outdated
Show resolved
Hide resolved
| const h = this.context.viewport.height; | ||
|
|
||
| const percentages = [50, 25, 75, 12.5, 87.5, 25, 75]; | ||
|
|
||
| const n = well_xyz?.length ?? 2; | ||
| if (well_xyz && n >= 2) { |
There was a problem hiding this comment.
Add some comments to explain the algorithm (are a ref to original if it comes from a known algo)
There was a problem hiding this comment.
BTW, I don't get the logic. If I understand correctly, if the algo fail with the provided percentage, a hard-coded list of percentages completely unrelated to the requested one is used.
There was a problem hiding this comment.
Please wait a bit with this code review. The Wellslayer.stories file is included by mistake
There was a problem hiding this comment.
This comment is not related to story, but to wellsLayer.ts
There was a problem hiding this comment.
This is a regular sampling along the trajectory in search of a camera visible location. It is shuffled to minimize large jumps and to tend towards the middle.
There was a problem hiding this comment.
What bothers me is that it does absolutely not take into account requested position.
I would use an approach to shift away from the requested position , not to ignore it
There was a problem hiding this comment.
What bothers me is that it does absolutely not take into account requested position.
I would use an approach to shift away from the requested position , not to ignore it
I agree, it could be better usability if the labels shifted more gradually from the requested position instead of popping up at a random position.
nilscb
force-pushed
the
WellClutterContinued
branch
from
6af52bb to
0537835
Compare
|
The auto positioning of lables is now default off and controlled by the well property "wellNameAutoPosition" |
| const h = this.context.viewport.height; | ||
|
|
||
| const percentages = [50, 25, 75, 12.5, 87.5, 25, 75]; | ||
|
|
||
| const n = well_xyz?.length ?? 2; | ||
| if (well_xyz && n >= 2) { |
There was a problem hiding this comment.
This comment is not related to story, but to wellsLayer.ts
| /** It true label position will be auto calculated if possible to be inside view volume at all times. | ||
| * default false. | ||
| */ | ||
| wellNameAutoPosition: boolean; |
There was a problem hiding this comment.
I would rename that to adjustWellNamePosition
| const h = this.context.viewport.height; | ||
|
|
||
| const percentages = [50, 25, 75, 12.5, 87.5, 25, 75]; | ||
|
|
||
| const n = well_xyz?.length ?? 2; | ||
| if (well_xyz && n >= 2) { |
There was a problem hiding this comment.
What bothers me is that it does absolutely not take into account requested position.
I would use an approach to shift away from the requested position , not to ignore it
|
If I disable |
