-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump @equinor/eds-core-react in /typescript #2429
Comments
@w1nklr I started investigating the issue and I managed to identify what is wrong. https://github.com/equinor/design-system/releases/tag/eds-core-react%400.41.3 The However, there are some failing tests remaining. From what I have seen so far, they are all checking if the popover elements are visible and that doesn't seem to work. I haven't had the time yet to investigate further, maybe we can adjust the tests. Alternatively, we could also disable them or pin the I opened a draft PR here: #2431 |
jsdom is currently used as an indirect dependency.
Not sure it is possible to bump jsdom from v20 to latest v26 ? |
@w1nklr I can definitely give it a try 👍. However, I don't have too high hopes as the issue asking for support for Popover API is still open: jsdom/jsdom#3721 |
Bumping @equinor/eds-core-react in /typescript fails.
Unit tests and smoke tests are failing. Snapshots from #2381 :
The text was updated successfully, but these errors were encountered: