Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack_sim issues with none UTF files #537

Closed
RezaeiDoust opened this issue May 4, 2023 · 7 comments · Fixed by #545 or #651
Closed

pack_sim issues with none UTF files #537

RezaeiDoust opened this issue May 4, 2023 · 7 comments · Fixed by #545 or #651
Assignees

Comments

@RezaeiDoust
Copy link

if any Norwegian letters is present in the DATA file ( like a comment on any lines explaining anything in Norwegian), the code exits with an error message.

Solutions:

  1. to make the code with any file type
  2. have a temporary copy of the DATA file in UTF and then delete it afterwards.
@alifbe
Copy link
Collaborator

alifbe commented May 5, 2023

Referring to offline discussion and internal yammer post, apparently, the file is encoded using ISO-8859-1 instead of UTF-8. It's probably remains from old Unix text editor.

Two possible solutions:

  1. Support ISO-8859-1 encoding in pack_sim
  2. Give a warning when the file is using non utf-8 encoding and probably a hint on how to convert it

Preferably to work on 2nd solution.

@RezaeiDoust
Copy link
Author

As it is reported before if any of the files (DATA or INCLUDE ) have sm³ (mainly reported within VFP files)the whole pack_sim exits with an error. I hope this can be fixed.

in large models it is very tedious to go within files, find and fix it one by one.

@mferrera mferrera reopened this Jan 17, 2024
@mferrera
Copy link
Collaborator

Understood, thanks for raising this again. We can take a look and see what the options are.

@HodjatMoradi
Copy link

I'm experiencing a similar problem in Gudrun when attempting to pack multiple ensembles. In my case It appears that the issue is originating from a software called Prosper which is resulting in problems with sub and superscript formatting such as sm3 or CO2 . If the problem is limited to these types of formatting, it may be feasible to provide support for them. As Ali mentioned, it can be a tedious task to go through numerous large files and attempt to fix them.

@mferrera
Copy link
Collaborator

We have fixed this so that it can read these files naturally. We'll get it into the next Komodo.

@RezaeiDoust
Copy link
Author

Thanks Matthew,
Any time lines for the updated Komodo?

@mferrera
Copy link
Collaborator

Updates for the next Komodo are due this Friday but testing before it is released can take anywhere from 1-3 weeks. There's never a firm timeline, but whenever the February Komodo comes out it will be in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants