From eb77acbbb59c458eb098f721a6422328236dbf8e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Therese=20Natter=C3=B8y?=
 <61694854+tnatt@users.noreply.github.com>
Date: Mon, 19 Feb 2024 13:17:46 +0100
Subject: [PATCH] Bugfix in rename_rms_scripts

---
 pyproject.toml                          |  1 +
 src/fmu/tools/rms/rename_rms_scripts.py |  6 ++---
 tests/rms/test_rename_rms_scripts.py    | 33 +++++++++++++++++++++++--
 3 files changed, 35 insertions(+), 5 deletions(-)

diff --git a/pyproject.toml b/pyproject.toml
index 9fed45e2..76845dcf 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -54,6 +54,7 @@ tests = [
     "pytest-cov",
     "pytest-runner",
     "pytest-xdist",
+    "pytest-mock", 
     "rstcheck",
     "types-PyYAML",
 ]
diff --git a/src/fmu/tools/rms/rename_rms_scripts.py b/src/fmu/tools/rms/rename_rms_scripts.py
index 490002f3..aef6bda9 100644
--- a/src/fmu/tools/rms/rename_rms_scripts.py
+++ b/src/fmu/tools/rms/rename_rms_scripts.py
@@ -509,11 +509,11 @@ def main() -> None:
 
     logging.basicConfig()
 
-    if args.verbose or args.test:
+    if args.verbose or args.test_run:
         _logger.setLevel(logging.INFO)
 
     # Don't write files if it's a test run
-    master = PythonCompMaster(args.path, write=not args.test)
+    master = PythonCompMaster(args.path, write=not args.test_run)
 
     if args.backup:
         _make_backup(master.parent)
@@ -522,7 +522,7 @@ def main() -> None:
     master.write_master_file()
     _print_skipped(skipped, master)
 
-    if args.verbose or args.test:
+    if args.verbose or args.test_run:
         unused = master.get_unused_scripts()
         _print_unused(unused, master)
 
diff --git a/tests/rms/test_rename_rms_scripts.py b/tests/rms/test_rename_rms_scripts.py
index 2c60afdb..a7d922fd 100644
--- a/tests/rms/test_rename_rms_scripts.py
+++ b/tests/rms/test_rename_rms_scripts.py
@@ -1,12 +1,12 @@
 import logging
 from filecmp import cmp
-from os import listdir
+from os import chdir, listdir
 from pathlib import Path
 from shutil import copytree
 from textwrap import dedent
 
 import pytest
-from fmu.tools.rms.rename_rms_scripts import PythonCompMaster
+from fmu.tools.rms.rename_rms_scripts import PythonCompMaster, main
 
 logging.basicConfig(level=logging.INFO)
 
@@ -248,3 +248,32 @@ def test_write_master_file(tmp_path):
     assert cmp(exp_py / ".master", project.path) is True
 
     assert set(listdir(exp_py)) == set(listdir(project.parent))
+
+
+def test_cmdline_main(tmp_path, mocker):
+    """Test the cmndline utility runs without errors. Both with and
+    without test-run option.
+    """
+    project_path = tmp_path / "snakeoil.rms13.0.3"
+    copytree(TESTPROJ, project_path)
+
+    mocker.patch("sys.argv", ["rename_rms_scripts", str(project_path)])
+    main()
+
+    mocker.patch("sys.argv", ["rename_rms_scripts", str(project_path)], "--test-run")
+    main()
+
+
+def test_cmdline_main_backup(tmp_path, mocker):
+    """Test the backup of the pythoncomp through the cmndline."""
+    project_path = tmp_path / "snakeoil.rms13.0.3"
+    copytree(TESTPROJ, project_path)
+
+    # change directory to store the backup in the tmp_path
+    chdir(tmp_path)
+
+    mocker.patch("sys.argv", ["rename_rms_scripts", str(project_path), "--backup"])
+    main()
+
+    # check that the backup exists
+    assert (tmp_path / "backup_pythoncomp").exists()